Snippets for httrack 3.49.11 from FreeBSD 150amd64

Sourced from https://pkg-status.freebsd.org/beefy23/data/latest-per-pkg/httrack/3.49.11/150amd64-default.log.

• htscore.c:722:13: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
    722 |     htsbuff primarybuff = htsbuff_ptr(primary, primary_len);
        |             ^
  

• htscore.c:2229:41: warning: sizeof on pointer operation will return size of 'char *' instead of 'char[1100]' [-Wsizeof-array-decay]
   2229 |                   strcatbuff(file, line + 1);
        |                                    ~~~~ ^
  

• htscore.c:2253:45: warning: sizeof on pointer operation will return size of 'char *' instead of 'char[1100]' [-Wsizeof-array-decay]
   2253 |                       strcatbuff(file, line + 1);
        |                                        ~~~~ ^
  

• htscore.c:2220:20: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
   2220 |               char line[1100];
        |                    ^
  

• htscore.c:2654:7: warning: variable 'npaths' set but not used [-Wunused-but-set-variable]
   2654 |   int npaths;
        |       ^
  

• htscore.c:2762:7: warning: variable 'npaths' set but not used [-Wunused-but-set-variable]
   2762 |   int npaths;
        |       ^
  

• htsparse.c:2143:42: warning: sizeof on pointer operation will return size of 'char *' instead of 'char[2048]' [-Wsizeof-array-decay]
   2143 |                   strcpybuff(tempo, lien + /* ./ */ 2);
        |                                     ~~~~ ^
  

• htsparse.c:2370:47: warning: sizeof on pointer operation will return size of 'char *' instead of 'char[2048]' [-Wsizeof-array-decay]
   2370 |                                          lien + ((*lien == '/') ? 1 : 0));
        |                                          ~~~~ ^
  

• htsparse.c:408:29: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
    408 |       const script_automate saut = {&inscript, inscript_state,
        |                             ^
  

• htsback.c:532:13: warning: comparison of array 'back->url_sav' not equal to a null pointer is always true [-Wtautological-pointer-compare]
    532 |   if (back->url_sav != NULL && back->url_sav[0] != '\0') {
        |       ~~~~~~^~~~~~~    ~~~~
  

• htsback.c:791:37: warning: comparison of array 'back[p].url_sav' not equal to a null pointer is always true [-Wtautological-pointer-compare]
    791 |                             back[p].url_sav != NULL ? back[p].url_sav : "");
        |                             ~~~~~~~~^~~~~~~    ~~~~
  

• htsback.c:2204:35: warning: address of array 'back[i].url_sav' will always evaluate to 'true' [-Wpointer-bool-conversion]
   2204 |                           back[i].url_sav ? back[i].url_sav : "<null>");
        |                           ~~~~~~~~^~~~~~~ ~
  

• htsback.c:2713:61: warning: cast from 'const char *' to 'void *' drops const qualifier [-Wcast-qual]
   2713 |                 SSL_set_tlsext_host_name(back[i].r.ssl_con, hostname);
        |                                                             ^
  

• htsdns_selftest.c:153:28: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
    153 |     struct addrinfo *const ai = mock_mkai(&h->addr[i]);
        |                            ^
  

• htsselftest.c:899:20: warning: variable 'result' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    899 |         } else if (bench[loop].type == TEST_ADD ||
        |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    900 |                    bench[loop].type == TEST_DEL) {
        |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• htsselftest.c:1772:28: warning: cast from 'const unsigned char *' to 'unsigned char *' drops const qualifier [-Wcast-qual]
   1772 |   strm.next_in = (Bytef *) src;
        |                            ^
  

• coucal/coucal.c:321:29: warning: format string is not a string literal [-Wformat-nonliteral]
    321 |     (void) vfprintf(stderr, format, args);
        |                             ^~~~~~
  

• htslib.c:895:19: warning: address of array 'retour->msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
    895 |       if (retour->msg) {
        |       ~~  ~~~~~~~~^~~
  

• htslib.c:2405:29: warning: address of array 'retour->msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
   2405 |       if (retour && retour->msg) {
        |                  ~~ ~~~~~~~~^~~
  

• htslib.c:2436:29: warning: address of array 'retour->msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
   2436 |       if (retour && retour->msg) {
        |                  ~~ ~~~~~~~~^~~
  

• htslib.c:2460:31: warning: address of array 'retour->msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
   2460 |         if (retour && retour->msg) {
        |                    ~~ ~~~~~~~~^~~
  

• htslib.c:2517:39: warning: address of array 'retour->msg' will always evaluate to 'true' [-Wpointer-bool-conversion]
   2517 |         if (retour != NULL && retour->msg) {
        |                            ~~ ~~~~~~~~^~~
  

• htslib.c:5630:25: warning: format string is not a string literal [-Wformat-nonliteral]
   5630 |     (void) vfprintf(fp, format, args);
        |                         ^~~~~~
  

• htslib.c:5706:20: warning: format string is not a string literal [-Wformat-nonliteral]
   5706 |   vfprintf(stderr, format, args);
        |                    ^~~~~~
  

• htslib.c:5902:31: warning: format string is not a string literal [-Wformat-nonliteral]
   5902 |     (void) vfprintf(opt->log, format, args);
        |                               ^~~~~~
  

• htsname.c:1036:44: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
   1036 |               htsbuff_cat(&sb, DEFAULT_EXT + 1); // skip the leading dot
        |                                ~~~~~~~~~~~~^~~
  

• htsname.c:1038:50: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
   1038 |               htsbuff_cat(&sb, DEFAULT_EXT_SHORT + 1); // skip the leading dot
        |                                ~~~~~~~~~~~~~~~~~~^~~
  

• htsname.c:1049:44: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
   1049 |               htsbuff_cat(&sb, DEFAULT_EXT + 1); // skip the leading dot
        |                                ~~~~~~~~~~~~^~~
  

• htsname.c:1051:50: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
   1051 |               htsbuff_cat(&sb, DEFAULT_EXT_SHORT + 1); // skip the leading dot
        |                                ~~~~~~~~~~~~~~~~~~^~~
  

• htsname.c:1367:33: warning: sizeof on pointer operation will return size of 'char *' instead of 'char[2048]' [-Wsizeof-array-decay]
   1367 |     strcpybuff(tempo, afs->save + 1);
        |                       ~~~~~~~~~ ^
  

• htsrobots.c:166:20: warning: passing 'const char *' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    166 |     bptr += binput(body + bptr, line, sizeof(line) - 2);
        |                    ^~~~~~~~~~~
  

• htstools.c:1226:23: warning: address of array 'find->dirp->d_name' will always evaluate to 'true' [-Wpointer-bool-conversion]
   1226 |       if (find->dirp->d_name)
        |       ~~  ~~~~~~~~~~~~^~~~~~
  

• htscharset.c:1139:32: warning: result of comparison of constant -1 with expression of type 'unsigned char' is always true [-Wtautological-constant-out-of-range-compare]
   1139 |               EMIT_UNICODE(uc, EM);
        |               ~~~~~~~~~~~~~~~~~^~~
  

• htscharset.c:1139:32: warning: result of comparison of constant -1 with expression of type 'const unsigned char' is always true [-Wtautological-constant-out-of-range-compare]
   1139 |               EMIT_UNICODE(uc, EM);
        |               ~~~~~~~~~~~~~~~~~^~~
  

• htscharset.c:1239:22: warning: result of comparison of constant -1 with expression of type 'unsigned char' is always true [-Wtautological-constant-out-of-range-compare]
   1239 |     EMIT_UNICODE(uc, EM);
        |     ~~~~~~~~~~~~~~~~~^~~
  

• htscharset.c:1239:22: warning: result of comparison of constant -1 with expression of type 'const unsigned char' is always true [-Wtautological-constant-out-of-range-compare]
   1239 |     EMIT_UNICODE(uc, EM);
        |     ~~~~~~~~~~~~~~~~~^~~
  

• minizip/zip.c:1931:15: warning: cast from 'char *' to 'short *' increases required alignment from 1 to 2 [-Wcast-align]
   1931 |     header = *(short*)p;
        |               ^~~~~~~~~
  

• minizip/zip.c:1932:19: warning: cast from 'char *' to 'short *' increases required alignment from 1 to 2 [-Wcast-align]
   1932 |     dataSize = *(((short*)p)+1);
        |                   ^~~~~~~~~
  

• /wrkdirs/usr/ports/www/httrack/work/httrack-3.49.11/src/coucal/coucal.c:321:29: warning: format string is not a string literal [-Wformat-nonliteral]
    321 |     (void) vfprintf(stderr, format, args);
        |                             ^~~~~~
  

• /usr/include/sys/timeb.h:41:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
     41 | #warning "this file includes <sys/timeb.h> which is deprecated"
        |  ^
  

• proxy/proxytrack.h:73:25: warning: format string is not a string literal [-Wformat-nonliteral]
     73 |     (void) vfprintf(fp, format, args);
        |                         ^~~~~~
  

• proxy/proxytrack.c:786:29: warning: address of array 'file->lastmodified' will always evaluate to 'true' [-Wpointer-bool-conversion]
    786 |                   if (file->lastmodified) {
        |                   ~~  ~~~~~~^~~~~~~~~~~~
  

• proxy/proxytrack.c:800:29: warning: address of array 'file->contenttype' will always evaluate to 'true' [-Wpointer-bool-conversion]
    800 |                   if (file->contenttype) {
        |                   ~~  ~~~~~~^~~~~~~~~~~
  

• proxy/store.c:2146:34: warning: size argument in 'strncat' call appears to be size of the source [-Wstrncat-size]
   2146 |             strncat(r->msg, pos, sizeof(pos) - 1);
        |                                  ^~~~~~~~~~~~~~~