Snippets for yacreader 9.16.3 from Fedora x86_64

Sourced from https://kojipkgs.fedoraproject.org/packages/yacreader/9.16.3/4.fc45/data/logs/x86_64/build.log.

• goto_dialog.cpp:63:27: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
     63 |     if (page >= 1 && page <= v->top()) {
        |                      ~~~~~^~~~~~~~~~~
  

• ../common/comic_db.cpp:38:52: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
     38 |     txt.append(QString("contrast:%1\r\n").arg(info.contrast));
        |                                                    ^~~~~~~~
  

• ../common/comic_db.cpp:279:7: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    279 |       brightness(-1),
        |       ^~~~~~~~~~~~~~
  

• ../common/comic_db.cpp:280:7: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    280 |       contrast(-1),
        |       ^~~~~~~~~~~~
  

• ../common/comic_db.cpp:281:7: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    281 |       gamma(-1)
        |       ^~~~~~~~~
  

• ../common/comic_db.cpp:286:15: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    286 |     : QObject()
        |               ^
  

• ../common/comic_db.cpp:286:15: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    286 |     : QObject()
        |               ^
  

• ../common/comic_db.cpp:286:15: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    286 |     : QObject()
        |               ^
  

• ../common/comic_db.cpp:367:5: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    367 |     brightness = comicInfo.brightness;
        |     ^~~~~~~~~~
  

• ../common/comic_db.cpp:367:28: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    367 |     brightness = comicInfo.brightness;
        |                            ^~~~~~~~~~
  

• ../common/comic_db.cpp:368:5: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    368 |     contrast = comicInfo.contrast;
        |     ^~~~~~~~
  

• ../common/comic_db.cpp:368:26: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    368 |     contrast = comicInfo.contrast;
        |                          ^~~~~~~~
  

• ../common/comic_db.cpp:369:5: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    369 |     gamma = comicInfo.gamma;
        |     ^~~~~
  

• ../common/comic_db.cpp:369:23: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    369 |     gamma = comicInfo.gamma;
        |                       ^~~~~
  

• ../common/comic_db.cpp:655:25: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    655 |     stream << comicInfo.brightness;
        |                         ^~~~~~~~~~
  

• ../common/comic_db.cpp:656:25: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    656 |     stream << comicInfo.contrast;
        |                         ^~~~~~~~
  

• ../common/comic_db.cpp:657:25: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    657 |     stream << comicInfo.gamma;
        |                         ^~~~~
  

• ../common/comic_db.cpp:740:25: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    740 |     stream >> comicInfo.brightness;
        |                         ^~~~~~~~~~
  

• ../common/comic_db.cpp:741:25: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    741 |     stream >> comicInfo.contrast;
        |                         ^~~~~~~~
  

• ../common/comic_db.cpp:742:25: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    742 |     stream >> comicInfo.gamma;
        |                         ^~~~~
  

• ../YACReaderLibrary/xml_info_library_scanner.cpp:32:101: warning: unused parameter ‘folder’ [-Wunused-parameter]
     32 | void XMLInfoLibraryScanner::scanFolder(const QString &source, const QString &target, const QString &folder, const QModelIndex &dest)
        |                                                                                      ~~~~~~~~~~~~~~~^~~~~~
  

• ../YACReaderLibrary/xml_info_library_scanner.cpp:108:9: warning: unused variable ‘id’ [-Wunused-variable]
    108 |     int id = record.indexOf("id");
        |         ^~
  

• viewer.cpp:1229:43: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1229 |         if (brightness != 0 || comic.info.brightness != -1)
        |                                           ^~~~~~~~~~
  

• viewer.cpp:1230:24: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1230 |             comic.info.brightness = brightness;
        |                        ^~~~~~~~~~
  

• viewer.cpp:1231:43: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1231 |         if (contrast != 100 || comic.info.contrast != -1)
        |                                           ^~~~~~~~
  

• viewer.cpp:1232:24: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1232 |             comic.info.contrast = contrast;
        |                        ^~~~~~~~
  

• viewer.cpp:1233:40: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1233 |         if (gamma != 100 || comic.info.gamma != -1)
        |                                        ^~~~~
  

• viewer.cpp:1234:24: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   1234 |             comic.info.gamma = gamma;
        |                        ^~~~~
  

• main.cpp:145:81: warning: unused parameter ‘args’ [-Wunused-parameter]
    145 | int start(QCoreApplication &app, QCommandLineParser &parser, const QStringList &args, QSettings *settings, QTextStream &qout)
        |                                                              ~~~~~~~~~~~~~~~~~~~^~~~
  

• ../YACReaderLibrary/library_creator.cpp:668:78: warning: comparison of integer expressions of different signedness: ‘qulonglong’ {aka ‘long long unsigned int’} and ‘qint64’ {aka ‘long long int’} [-Wsign-compare]
    668 |                                 auto sizeHasChanged = comicDB->getFileSize() != fileInfoS.size();
        |                                                       ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
  

• ../YACReaderLibrary/library_creator.cpp:669:75: warning: comparison of integer expressions of different signedness: ‘long long unsigned int’ and ‘long long int’ [-Wsign-compare]
    669 |                                 auto hasBeenModified = added > 0 && added < lastModified && checkModifiedDatesOnUpdate;
        |                                                                     ~~~~~~^~~~~~~~~~~~~~
  

• goto_flow_toolbar.cpp:114:27: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
    114 |     if (page >= 1 && page <= v->top()) {
        |                      ~~~~~^~~~~~~~~~~
  

• /usr/include/qt5/QtCore/qvector.h:1013:13: warning: ‘realIdx’ may be used uninitialized [-Wmaybe-uninitialized]
   1013 |             if (*n == t)
        |             ^~
  

• ../YACReaderLibrary/db/query_parser.cpp:33:73: warning: unused parameter ‘expOperator’ [-Wunused-parameter]
     33 | std::string parseDate(const std::string &dateString, const std::string &expOperator)
        |                                                      ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
  

• main_window_viewer.cpp:838:51: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    838 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                   ^~~~~~~~~~
  

• main_window_viewer.cpp:838:83: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    838 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                                                   ^~~~~~~~
  

• main_window_viewer.cpp:838:113: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    838 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                                                                                 ^~~~~
  

• main_window_viewer.cpp:866:51: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    866 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                   ^~~~~~~~~~
  

• main_window_viewer.cpp:866:83: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    866 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                                                   ^~~~~~~~
  

• main_window_viewer.cpp:866:113: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    866 |     optionsDialog->setFilters(currentComicDB.info.brightness, currentComicDB.info.contrast, currentComicDB.info.gamma);
        |                                                                                                                 ^~~~~
  

• ../YACReaderLibrary/db_helper.cpp:771:57: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    771 |     updateComicInfo.bindValue(":brightness", comicInfo->brightness);
        |                                                         ^~~~~~~~~~
  

• ../YACReaderLibrary/db_helper.cpp:772:55: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    772 |     updateComicInfo.bindValue(":contrast", comicInfo->contrast);
        |                                                       ^~~~~~~~
  

• ../YACReaderLibrary/db_helper.cpp:773:52: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    773 |     updateComicInfo.bindValue(":gamma", comicInfo->gamma);
        |                                                    ^~~~~
  

• ../YACReaderLibrary/db_helper.cpp:2031:15: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2031 |     comicInfo.brightness = query.value(brightness).toInt();
        |               ^~~~~~~~~~
  

• ../YACReaderLibrary/db_helper.cpp:2032:15: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2032 |     comicInfo.contrast = query.value(contrast).toInt();
        |               ^~~~~~~~
  

• ../YACReaderLibrary/db_helper.cpp:2033:15: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2033 |     comicInfo.gamma = query.value(gamma).toInt();
        |               ^~~~~
  

• render.cpp:667:30: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    667 |             if (comicDB.info.brightness == -1)
        |                              ^~~~~~~~~~
  

• render.cpp:670:51: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    670 |                 filters[i]->setLevel(comicDB.info.brightness);
        |                                                   ^~~~~~~~~~
  

• render.cpp:673:30: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    673 |             if (comicDB.info.contrast == -1)
        |                              ^~~~~~~~
  

• render.cpp:676:51: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    676 |                 filters[i]->setLevel(comicDB.info.contrast);
        |                                                   ^~~~~~~~
  

• render.cpp:679:30: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    679 |             if (comicDB.info.gamma == -1)
        |                              ^~~~~
  

• render.cpp:682:51: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    682 |                 filters[i]->setLevel(comicDB.info.gamma);
        |                                                   ^~~~~
  

• ../YACReaderLibrary/server/yacreader_server_data_helper.cpp:170:37: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    170 |     json["brightness"] = comic.info.brightness;
        |                                     ^~~~~~~~~~
  

• ../YACReaderLibrary/server/yacreader_server_data_helper.cpp:171:35: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    171 |     json["contrast"] = comic.info.contrast;
        |                                   ^~~~~~~~
  

• ../YACReaderLibrary/server/yacreader_server_data_helper.cpp:172:32: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    172 |     json["gamma"] = comic.info.gamma;
        |                                ^~~~~
  

• ../YACReaderLibrary/server/controllers/v1/synccontroller.cpp:50:49: warning: ‘static void DBHelper::updateFromRemoteClient(qulonglong, const ComicInfo&)’ is deprecated: Server v1 [-Wdeprecated-declarations]
     50 |                 DBHelper::updateFromRemoteClient(libraryId, info);
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
  

• ../YACReaderLibrary/server/controllers/v1/foldercontroller.cpp:236:13: warning: variable ‘xyz’ set but not used [-Wunused-but-set-variable=]
    236 |         int xyz = 1;
        |             ^~~
  

• /usr/include/qt5/QtWidgets/qdialog.h:94:18: warning: ‘virtual void QDialog::open()’ was hidden [-Woverloaded-virtual=]
     94 |     virtual void open();
        |                  ^~~~
  

• folder_content_view.cpp:322:55: warning: unused parameter ‘formats’ [-Wunused-parameter]
    322 | bool FolderContentView::canDropFormats(const QString &formats)
        |                                        ~~~~~~~~~~~~~~~^~~~~~~
  

• library_creator.cpp:668:78: warning: comparison of integer expressions of different signedness: ‘qulonglong’ {aka ‘long long unsigned int’} and ‘qint64’ {aka ‘long long int’} [-Wsign-compare]
    668 |                                 auto sizeHasChanged = comicDB->getFileSize() != fileInfoS.size();
        |                                                       ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
  

• library_creator.cpp:669:75: warning: comparison of integer expressions of different signedness: ‘long long unsigned int’ and ‘long long int’ [-Wsign-compare]
    669 |                                 auto hasBeenModified = added > 0 && added < lastModified && checkModifiedDatesOnUpdate;
        |                                                                     ~~~~~~^~~~~~~~~~~~~~
  

• db/folder_model.cpp:347:45: warning: unused parameter ‘index’ [-Wunused-parameter]
    347 | void FolderModel::reload(const QModelIndex &index)
        |                          ~~~~~~~~~~~~~~~~~~~^~~~~
  

• xml_info_library_scanner.cpp:32:101: warning: unused parameter ‘folder’ [-Wunused-parameter]
     32 | void XMLInfoLibraryScanner::scanFolder(const QString &source, const QString &target, const QString &folder, const QModelIndex &dest)
        |                                                                                      ~~~~~~~~~~~~~~~^~~~~~
  

• xml_info_library_scanner.cpp:108:9: warning: unused variable ‘id’ [-Wunused-variable]
    108 |     int id = record.indexOf("id");
        |         ^~
  

• db_helper.cpp:771:57: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    771 |     updateComicInfo.bindValue(":brightness", comicInfo->brightness);
        |                                                         ^~~~~~~~~~
  

• db_helper.cpp:772:55: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    772 |     updateComicInfo.bindValue(":contrast", comicInfo->contrast);
        |                                                       ^~~~~~~~
  

• db_helper.cpp:773:52: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    773 |     updateComicInfo.bindValue(":gamma", comicInfo->gamma);
        |                                                    ^~~~~
  

• db_helper.cpp:2031:15: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2031 |     comicInfo.brightness = query.value(brightness).toInt();
        |               ^~~~~~~~~~
  

• db_helper.cpp:2032:15: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2032 |     comicInfo.contrast = query.value(contrast).toInt();
        |               ^~~~~~~~
  

• db_helper.cpp:2033:15: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
   2033 |     comicInfo.gamma = query.value(gamma).toInt();
        |               ^~~~~
  

• server/controllers/v1/synccontroller.cpp:50:49: warning: ‘static void DBHelper::updateFromRemoteClient(qulonglong, const ComicInfo&)’ is deprecated: Server v1 [-Wdeprecated-declarations]
     50 |                 DBHelper::updateFromRemoteClient(libraryId, info);
        |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
  

• server/yacreader_server_data_helper.cpp:170:37: warning: ‘ComicInfo::brightness’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    170 |     json["brightness"] = comic.info.brightness;
        |                                     ^~~~~~~~~~
  

• server/yacreader_server_data_helper.cpp:171:35: warning: ‘ComicInfo::contrast’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    171 |     json["contrast"] = comic.info.contrast;
        |                                   ^~~~~~~~
  

• server/yacreader_server_data_helper.cpp:172:32: warning: ‘ComicInfo::gamma’ is deprecated: Use imageFiltersJson [-Wdeprecated-declarations]
    172 |     json["gamma"] = comic.info.gamma;
        |                                ^~~~~
  

• db/query_parser.cpp:33:73: warning: unused parameter ‘expOperator’ [-Wunused-parameter]
     33 | std::string parseDate(const std::string &dateString, const std::string &expOperator)
        |                                                      ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
  

• server/controllers/v1/foldercontroller.cpp:236:13: warning: variable ‘xyz’ set but not used [-Wunused-but-set-variable=]
    236 |         int xyz = 1;
        |             ^~~