Snippets for adplug 2.3.3 from Fedora i686

Sourced from https://kojipkgs.fedoraproject.org/packages/adplug/2.3.3/16.fc45/data/logs/i686/build.log.

src/adlibemu.c:147:10: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  147 |     if (*(long *)&ctc->amp <= 0x37800000)
      |          ^~~~~~~~~~~~~~~~~

src/adlibemu.c:163:11: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  163 |     if ((*(long *)&ctc->amp) <= (*(long *)&ctc->sustain))
      |           ^~~~~~~~~~~~~~~~~

src/adlibemu.c:163:35: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  163 |     if ((*(long *)&ctc->amp) <= (*(long *)&ctc->sustain))
      |                                   ^~~~~~~~~~~~~~~~~~~~~

src/adlibemu.c:186:11: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  186 |     if ((*(long *)&ctc->amp) > 0x3f800000)
      |           ^~~~~~~~~~~~~~~~~

adplugdb/adplugdb.cpp:185:7: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  185 |     if((p = (*i)->factory(&opl)))
      |       ^

src/a2m.cpp:175:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  175 |       if(numpats > 16)
      |       ^~

src/a2m.cpp:177:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  177 |       if(numpats > 32)
      |       ^~

src/a2m.cpp:182:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  182 |       if(numpats > 8)
      |       ^~

src/a2m.cpp:184:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  184 |       if(numpats > 16)
      |       ^~

src/a2m.cpp:186:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  186 |       if(numpats > 24)
      |       ^~

src/a2m.cpp:188:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  188 |       if(numpats > 32)
      |       ^~

src/a2m.cpp:190:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  190 |       if(numpats > 40)
      |       ^~

src/a2m.cpp:192:7: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  192 |       if(numpats > 48)
      |       ^~

src/a2m.cpp:69:17: warning: variable ‘crc’ set but not used [-Wunused-but-set-variable=]
   69 |   unsigned long crc, alength;
      |                 ^~~

src/adl.cpp:2561:44: warning: ‘)’ directive writing 1 byte into a region of size between 0 and 2 [-Wformat-overflow=]
 2561 |   sprintf(tmpstr, "Westwood ADL (version %d)", _version);
      |                                            ^

src/opl.h:62:16: warning: ‘virtual void Copl::update(short int*, int)’ was hidden [-Woverloaded-virtual=]
   62 |   virtual void update(short *buf, int samples) {}
      |                ^~~~~~

src/d00.cpp:465:15: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  465 |   if (subsong < getsubsongs() && dataofs + sizeof(Stpoin) <= filesize)
      |       ~~~~~~~~^~~~~~~~~~~~~~~

src/cmfmcsop.cpp:200:35: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  200 |                 for (int j = 0; j < sizeof(loadOffsets)/sizeof(loadOffsets[0]); ++j) {
      |                                 ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/cmfmcsop.cpp:415:80: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  415 |                                 if (currentOrderIndex < 0 || currentOrderIndex >= sizeof(patternOrder) / sizeof(patternOrder[0]))
      |                                                              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/cmfmcsop.cpp:422:66: warning: comparison of integer expressions of different signedness: ‘int16_t’ {aka ‘short int’} and ‘std::vector<std::vector<CcmfmacsoperaPlayer::NoteEvent> >::size_type’ {aka ‘unsigned int’} [-Wsign-compare]
  422 |                         } while (patternOrder[currentOrderIndex] >= patterns.size()); // loop to skip invalid pattern references
      |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~

src/cmfmcsop.cpp:429:41: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<CcmfmacsoperaPlayer::NoteEvent>::size_type’ {aka ‘unsigned int’} [-Wsign-compare]
  429 |                 if (currentPatternIndex < p.size() && p[currentPatternIndex].row == currentRow && p[currentPatternIndex].note == 1) {
      |                     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/cmfmcsop.cpp:467:36: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector<CcmfmacsoperaPlayer::NoteEvent>::size_type’ {aka ‘unsigned int’} [-Wsign-compare]
  467 |         for (; currentPatternIndex < p.size() && p[currentPatternIndex].row == currentRow; ++currentPatternIndex) {
      |                ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/dro2.cpp:69:27: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
   69 |             this->iLength > fp.filesize(f) - f->pos()) {
      |             ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/dro.cpp:76:48: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare]
   76 |         if (this->iLength < 3 || this->iLength > fp.filesize(f) - f->pos()) {
      |                                  ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/herad.cpp:1252:50: warning: comparison of integer expressions of different signedness: ‘int32_t’ {aka ‘int’} and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
 1252 |         if (wLoopStart && wLoopEnd && (ticks_pos == total_ticks || (ticks_pos % HERAD_MEASURE_TICKS == 0 && ticks_pos / HERAD_MEASURE_TICKS + 1 == wLoopEnd)))
      |                                        ~~~~~~~~~~^~~~~~~~~~~~~~

src/jbm.cpp:77:41: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘int’ [-Wsign-compare]
   77 |   if (f->readString((char *)m, filelen) != filelen) goto loaderr;
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/ksm.cpp:243:47: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  243 |     instbuf[1] = ((instbuf[1]&192)|(trvol[11])^63);
      |                                    ~~~~~~~~~~~^~~

src/ksm.cpp:249:47: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  249 |     instbuf[1] = ((instbuf[1]&192)|(trvol[12])^63);
      |                                    ~~~~~~~~~~~^~~

src/ksm.cpp:250:47: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  250 |     instbuf[6] = ((instbuf[6]&192)|(trvol[15])^63);
      |                                    ~~~~~~~~~~~^~~

src/ksm.cpp:256:47: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  256 |     instbuf[1] = ((instbuf[1]&192)|(trvol[14])^63);
      |                                    ~~~~~~~~~~~^~~

src/ksm.cpp:257:47: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  257 |     instbuf[6] = ((instbuf[6]&192)|(trvol[13])^63);
      |                                    ~~~~~~~~~~~^~~

src/lds.cpp:169:5: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  169 |   if(fadeonoff)
      |     ^

src/lds.cpp:210:11: warning: suggest explicit braces to avoid ambiguous ‘else’ [-Wdangling-else]
  210 |         if(comword)
      |           ^

src/mkj.cpp:140:42: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  140 |         if ((songbuf[channel[c].songptr] - 300 | 0xff) != 0xff)
      |              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~

src/mid.cpp:970:57: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare]
  970 |                     strnlen((char *)data + i, flen - i) < flen - i)
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/mid.cpp:974:57: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare]
  974 |                     strnlen((char *)data + i, flen - i) < flen - i)
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/mid.cpp:978:57: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare]
  978 |                     strnlen((char *)data + i, flen - i) < flen - i)
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

src/mid.cpp:1065:62: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘long int’ [-Wsign-compare]
 1065 |                 while (datalook(sierra_pos-2) != 0xff && pos < flen)
      |                                                          ~~~~^~~~~~

src/protrack.cpp:141:14: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  141 |     case 10: if(del % 4)        // SA2 volume slide
      |              ^~

src/protrack.cpp:149:14: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  149 |     case 14: if(info1 == 3)     // retrig note
      |              ^~

src/protrack.cpp:153:14: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  153 |     case 16: if(del % 4)        // AMD volume slide
      |              ^~

src/protrack.cpp:645:66: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  645 |     opl->write(0xb0 + oplchan, ((channel[chan].freq & 768) >> 8) + (channel[chan].oct << 2) | 32);
      |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

src/rad2.cpp:116:41: warning: unused variable ‘octave’ [-Wunused-variable]
  116 |                                 uint8_t octave = (note >> 4) & 7;
      |                                         ^~~~~~

src/rad2.cpp:198:41: warning: unused variable ‘param’ [-Wunused-variable]
  198 |                                 uint8_t param = *s++;
      |                                         ^~~~~

src/rad2.cpp:182:33: warning: unused variable ‘notenum’ [-Wunused-variable]
  182 |                         uint8_t notenum = note & 15;
      |                                 ^~~~~~~

src/rad2.cpp:183:33: warning: unused variable ‘octave’ [-Wunused-variable]
  183 |                         uint8_t octave = (note >> 4) & 7;
      |                                 ^~~~~~

src/rad2.cpp:69:20: warning: ‘g_RADExtraBytes’ defined but not used [-Wunused-variable]
   69 | static const char *g_RADExtraBytes = "Tune file contains extra bytes.";
      |                    ^~~~~~~~~~~~~~~

src/rix.cpp:185:21: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
  185 |   register uint16_t i;
      |                     ^

src/rix.cpp:397:16: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
  397 |   register int temp = 0;
      |                ^~~~

src/rix.cpp:410:21: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
  410 |   register uint16_t i = index>=12?index-12:0;
      |                     ^

src/rix.cpp:446:21: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
  446 |   register uint16_t i;
      |                     ^

src/rix.cpp:524:16: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
  524 |   register int i;
      |                ^

src/sng.cpp:76:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
   76 |   if(data[pos].val) del = data[pos].val - 1; pos++;
      |   ^~

src/s3m.cpp:355:17: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  355 |       case 8:   if((channel[realchan].fx == 7 ||        // vibrato (remember info for dual commands)
      |                 ^~

src/s3m.cpp:360:16: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  360 |       case 19: if(info == 0xb0)                         // set loop start
      |                ^~

src/sop.cpp:99:46: warning: comparison of integer expressions of different signedness: ‘long unsigned int’ and ‘int’ [-Wsign-compare]
   99 |                 check != 0 || fp.filesize(f) < SOP_HEAD_SIZE + nTracks)
      |                               ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

src/sop.cpp:167:23: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
  167 |         for (i = 0; i < nTracks + 1; i++) track[i].data = 0;
      |                     ~~^~~~~~~~~~~~~

src/sop.cpp:168:23: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
  168 |         for (i = 0; i < nTracks + 1; i++)
      |                     ~~^~~~~~~~~~~~~

src/sop.cpp:601:69: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  601 |                         SndOutput3(VolReg[chan - 11] - 3, KSL_value & 0xC0 | volume);
      |                                                           ~~~~~~~~~~^~~~~~

src/sop.cpp:603:99: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  603 |                         SndOutput1((percussion ? VolReg[chan + 11] : VolReg[chan]) - 3, KSL_value & 0xC0 | volume);
      |                                                                                         ~~~~~~~~~~^~~~~~

src/sop.cpp:610:73: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  610 |                                 SndOutput3(VolReg[chan - 11], KSL_value & 0xC0 | volume);
      |                                                               ~~~~~~~~~~^~~~~~

src/sop.cpp:612:68: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  612 |                                 SndOutput1(VolReg[chan], KSL_value & 0xC0 | volume);
      |                                                          ~~~~~~~~~~^~~~~~

src/sop.cpp:618:85: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  618 |                                         SndOutput3(VolReg[chan - 11] - 3, KSL_value & 0xC0 | volume);
      |                                                                           ~~~~~~~~~~^~~~~~

src/sop.cpp:620:80: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  620 |                                         SndOutput1(VolReg[chan] - 3, KSL_value & 0xC0 | volume);
      |                                                                      ~~~~~~~~~~^~~~~~

src/sop.cpp:627:73: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  627 |                                 SndOutput3(VolReg[chan - 11], KSL_value & 0xC0 | volume);
      |                                                               ~~~~~~~~~~^~~~~~

src/sop.cpp:629:103: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  629 |                                 SndOutput1((percussion ? VolReg[chan + 11] : VolReg[chan]), KSL_value & 0xC0 | volume);
      |                                                                                             ~~~~~~~~~~^~~~~~

src/sop.cpp:637:77: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  637 |                                 SndOutput3(VolReg[chan + 3 - 11], KSL_value & 0xC0 | volume);
      |                                                                   ~~~~~~~~~~^~~~~~

src/sop.cpp:639:72: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  639 |                                 SndOutput1(VolReg[chan + 3], KSL_value & 0xC0 | volume);
      |                                                              ~~~~~~~~~~^~~~~~

src/sop.cpp:645:81: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  645 |                                         SndOutput3(VolReg[chan - 11], KSL_value & 0xC0 | volume);
      |                                                                       ~~~~~~~~~~^~~~~~

src/sop.cpp:647:76: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  647 |                                         SndOutput1(VolReg[chan], KSL_value & 0xC0 | volume);
      |                                                                  ~~~~~~~~~~^~~~~~

src/sop.cpp:654:73: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  654 |                                 SndOutput3(VolReg[chan - 11], KSL_value & 0xC0 | volume);
      |                                                               ~~~~~~~~~~^~~~~~

src/sop.cpp:656:103: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  656 |                                 SndOutput1((percussion ? VolReg[chan + 11] : VolReg[chan]), KSL_value & 0xC0 | volume);
      |                                                                                             ~~~~~~~~~~^~~~~~

src/sop.cpp:736:57: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  736 |                         SndOutput1(i + 3, *(array + 16) & 0x0F | Stereo[chan]);
      |                                           ~~~~~~~~~~~~~~^~~~~~

src/vgm.cpp:165:29: warning: unused variable ‘gd3_ver’ [-Wunused-variable]
  165 |                         int gd3_ver = f->readInt(4);
      |                             ^~~~~~~

src/vgm.cpp:166:29: warning: unused variable ‘gd3_size’ [-Wunused-variable]
  166 |                         int gd3_size = f->readInt(4);
      |                             ^~~~~~~~

src/u6m.cpp:266:25: warning: ‘pW’ may be used uninitialized [-Wmaybe-uninitialized]
  266 |               get_string(pW,dictionary,root_stack);
      |               ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

src/woodyopl.cpp:1120:63: warning: storing the address of local variable ‘trem_lut’ in ‘tremval4’ [-Wdangling-pointer=]
 1120 |                                 if (cptr[9].tremolo) tremval4 = trem_lut;       // tremolo enabled, use table
      |                                                      ~~~~~~~~~^~~~~~~~~~

src/woodyopl.cpp:1110:63: warning: storing the address of local variable ‘trem_lut’ in ‘tremval2’ [-Wdangling-pointer=]
 1110 |                                 if (cptr[9].tremolo) tremval2 = trem_lut;       // tremolo enabled, use table
      |                                                      ~~~~~~~~~^~~~~~~~~~

src/woodyopl.cpp:1108:63: warning: storing the address of local variable ‘trem_lut’ in ‘tremval1’ [-Wdangling-pointer=]
 1108 |                                 if (cptr[0].tremolo) tremval1 = trem_lut;       // tremolo enabled, use table
      |                                                      ~~~~~~~~~^~~~~~~~~~

src/woodyopl.cpp:1080:63: warning: storing the address of local variable ‘trem_lut’ in ‘tremval3’ [-Wdangling-pointer=]
 1080 |                                 if (cptr[0].tremolo) tremval3 = trem_lut;       // tremolo enabled, use table
      |                                                      ~~~~~~~~~^~~~~~~~~~