Snippets for 7kaa 2.15.6 from FreeBSD 150arm64

Sourced from https://pkg-status.freebsd.org/ampere5/data/latest-per-pkg/7kaa/2.15.6/150arm64-default.log.

• ../include/OMATRIX.h:223:45: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
    223 |         int     wall_town_recno()       { return cargo_recno || 0xFF; }
        |                                                              ^  ~~~~
  

• OAI_CAP2.cpp:460:60: warning: '/*' within block comment [-Wcomment]
    460 |                 if( townPtr->nation_recno == targetTown->nation_recno ) //**BUGHERE
        |                                                                          ^
  

• OCOLTBL.cpp:124:13: warning: assigning field to itself [-Wself-assign-field]
    124 |         table_size = table_size;
        |                    ^
  

• OGAMENCY.cpp:219:23: warning: for loop has empty body [-Wempty-body]
    219 |                                 ++monsterSubClass);
        |                                                   ^
  

• OGAMENCY.cpp:403:22: warning: for loop has empty body [-Wempty-body]
    403 |                         ++monsterSubClass);
        |                                           ^
  

• OGAMEMP.cpp:3574:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
   3574 |                                 if( keyCode = mapIdField.detect() )
        |                                     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
  

• OGETA.cpp:491:19: warning: for loop has empty body [-Wempty-body]
    491 |                                 --cursor_pos );
        |                                               ^
  

• OGETA.cpp:511:18: warning: for loop has empty body [-Wempty-body]
    511 |                         --cursor_pos );
        |                                       ^
  

• OGFILE2.cpp:914:42: warning: 'memset' call operates on objects of type 'unsigned char' while the size is based on a different type 'unsigned char *' [-Wsizeof-pointer-memaccess]
    914 |                 memset(town_name_used_array, 0, sizeof(town_name_used_array));
        |                        ~~~~~~~~~~~~~~~~~~~~            ^~~~~~~~~~~~~~~~~~~~
  

• OGFILE2.cpp:1103:36: warning: 'memset' call operates on objects of type 'GodInfo' while the size is based on a different type 'GodInfo *' [-Wsizeof-pointer-memaccess]
   1103 |                 memset(god_info_array, 0, sizeof(god_info_array));
        |                        ~~~~~~~~~~~~~~            ^~~~~~~~~~~~~~
  

• OMISC.cpp:907:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    907 |                 "<C7><FC><E9><E2><E4><E0><E5><E7><EA><EB><E8><EF><EE><EC><C4><C5>"
        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• OMISC.cpp:908:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    908 |                 "<C9><E6><C6><F4><F6><F2><FB><F9><FF><D6><DC><F8><A3><D8><D7>\x83"
        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• OMISC.cpp:909:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    909 |                 "<E1><ED><F3><FA><F1>Ѫ<BA><BF>\xae<AC><BD><BC><A1><AB><BB>"
        |                  ^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~
  

• OMISC.cpp:909:17: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    909 |                 "<E1><ED><F3><FA><F1>Ѫ<BA><BF>\xae<AC><BD><BC><A1><AB><BB>"
        |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~
  

• OMISC.cpp:910:9: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    910 |                 "?????<C1><C2><C0><A9>????<A2><A5>?"
        |                       ^~~~~~~~~~~~~~~~    ~~~~~~~~
  

• OMISC.cpp:911:10: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    911 |                 "??????<E3><C3>???????<A4>"
        |                        ^~~~~~~~       ~~~~
  

• OMISC.cpp:912:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    912 |                 "<F0><D0><CA><CB><C8>'<CD><CE><CF>????<A6><CC>?"
        |                  ^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~    ~~~~~~~~
  

• OMISC.cpp:913:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    913 |                 "<D3><DF><D4><D2><F5>յ<DE><FE><DA><DB><D9><FD><DD>?<B4>"
        |                  ^~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~
  

• OMISC.cpp:914:4: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
    914 |                 "<B7><B1>=<BE><B6><A7><F7>?<B0><A8>?<B9><B3><B2>??";
        |                  ^~~~~~~~ ~~~~~~~~~~~~~~~~ ~~~~~~~~ ~~~~~~~~~~~~
  

• OMOUSE.cpp:397:9: warning: enumeration values 'KEY_PRESS', 'KEY_RELEASE', and 'KEY_TYPING' not handled in switch [-Wswitch]
    397 |         switch(type)
        |                ^~~~
  

• OMP_CRC.cpp:463:9: warning: destination for this 'memset' call is a pointer to dynamic class 'Sprite'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
    463 |         memset(&splash, 0, sizeof(splash));
        |         ~~~~~~ ^
  

• OMP_CRC.cpp:500:2: warning: 'sizeof (&c->unit_recno_array)' will return the size of the pointer, not the array itself [-Wsizeof-pointer-div]
    500 |         RTRIM_ARRAY(&c->unit_recno_array, unit_count);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• OMP_CRC.cpp:1253:9: warning: destination for this 'memcpy' call is a pointer to dynamic class 'NationBase'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
   1253 |         memcpy(&dummyNationBase, this, sizeof(NationBase));
        |         ~~~~~~ ^
  

• OMP_CRC.cpp:1342:9: warning: destination for this 'memset' call is a pointer to dynamic class 'Sprite'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
   1342 |         memset(&act_bullet, 0, sizeof(act_bullet));
        |         ~~~~~~ ^
  

• OMP_CRC.cpp:1343:9: warning: destination for this 'memset' call is a pointer to dynamic class 'Sprite'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
   1343 |         memset(&bullet_shadow, 0, sizeof(bullet_shadow));
        |         ~~~~~~ ^
  

• ONATIONB.cpp:80:10: warning: destination for this 'memset' call is a pointer to dynamic class 'NationBase'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
     80 |         memset( this, 0, sizeof(NationBase) );
        |         ~~~~~~  ^
  

• OREMOTEM.cpp:1610:6: warning: '/*' within block comment [-Wcomment]
   1610 | /*              //**BUGHERE, no more training in game 
        |                  ^
  

• OUNITAT2.cpp:2314:25: warning: self-comparison always evaluates to true [-Wtautological-compare]
   2314 |                 unitPtr->action_para2 == unitPtr->action_para2 &&
        |                                       ^
  

• OUNITD.cpp:1101:13: warning: '/*' within block comment [-Wcomment]
   1101 |                 stop2(); //**** BUGHERE
        |                           ^
  

• OUNITD.cpp:1102:19: warning: '/*' within block comment [-Wcomment]
   1102 |                 //set_mode(0); //***BUGHERE
        |                                 ^
  

• OU_MARIT.cpp:942:38: warning: left operand of comma operator has no effect [-Wunused-value]
    942 |                 for(j=0; j<linked_market_num; j++, marketNodePtr, firmSelectedPtr++)
        |                                                    ^~~~~~~~~~~~~