Snippets for abuse 0.8 from FreeBSD 150amd64

Sourced from https://pkg-status.freebsd.org/beefy23/data/latest-per-pkg/abuse_sdl/0.8_9/150amd64-default.log.

• ./../extend.h:119:43: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    119 |   void set_fxvel(uint8_t xv)      { Fxvel=abs(xv); }
        |                                           ^
  

• ./../extend.h:120:43: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    120 |   void set_fyvel(uint8_t yv)      { Fyvel=abs(yv); }
        |                                           ^
  

• ./../extend.h:121:44: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    121 |   void set_fxacel(uint8_t xa)     { Fxacel=abs(xa); }
        |                                            ^
  

• ./../extend.h:122:44: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    122 |   void set_fyacel(uint8_t ya)     { Fyacel=abs(ya); }
        |                                            ^
  

• ./../dev.h:135:16: warning: 'dev_term::execute' hides overloaded virtual function [-Woverloaded-virtual]
    135 |   virtual void execute(char *st);
        |                ^
  

• lisp.cpp:870:9: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
    870 |     if (this && item_type(this) != (ltype)L_CONS_CELL)
        |         ^~~~ ~~
  

• lisp.cpp:1278:14: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
   1278 |         if (!this)
        |             ~^~~~
  

• lisp.cpp:3083:9: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
   3083 |     if (this)
        |     ~~  ^~~~
  

• ./lisp_gc.h:45:29: warning: cast from 'LObject *const *' to 'void **' drops const qualifier [-Wcast-qual]
     45 |         stack.push((void **)&ref);
        |                             ^
  

• ./../netface.h:116:54: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    116 |   uint16_t get_checksum()            { uint16_t cs=*((uint16_t *)data+1); return lstl(cs); }
        |                                                      ^~~~~~~~~~~~~~~~
  

• ./../netface.h:119:7: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    119 |     *((uint16_t *)data+1)=0;
        |       ^~~~~~~~~~~~~~~~
  

• ./../netface.h:128:7: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    128 |     *((uint16_t *)data+1)=lstl(cs);
        |       ^~~~~~~~~~~~~~~~
  

• gserver.cpp:241:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
    241 |   int ret=0;
        |       ^
  

• ./tcpip.h:227:32: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
    227 |       return ::write(fd,(char*)buf,size);
        |                                ^
  

• tcpip.cpp:83:50: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
     83 |   net_log("tcpip.cpp: unix_fd::write:", (char *) buf, (long) size);
        |                                                  ^
  

• tcpip.cpp:86:28: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
     86 |   return ::write(fd,(char*)buf,size);
        |                            ^
  

• tcpip.cpp:481:13: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
    481 |             if (!found) {
        |             ^
  

• image.cpp:964:17: warning: variable 'i' set but not used [-Wunused-but-set-variable]
    964 |   int16_t x, y, i, j;
        |                 ^
  

• image.cpp:1067:7: warning: misleading indentation; statement is not part of the previous 'for' [-Wmisleading-indentation]
   1067 |       im->PutPixel(vec2i(i, j), t/d);
        |       ^
  

• input.cpp:109:11: warning: cast from 'char *' to 'int *' increases required alignment from 1 to 4 [-Wcast-align]
    109 |     if (*((int *)b->read())==0)
        |           ^~~~~~~~~~~~~~~~
  

• input.cpp:134:15: warning: cast from 'char *' to 'int *' increases required alignment from 1 to 4 [-Wcast-align]
    134 |         if (*((int *)b2->read())==0)
        |               ^~~~~~~~~~~~~~~~~
  

• input.cpp:137:13: warning: cast from 'char *' to 'int *' increases required alignment from 1 to 4 [-Wcast-align]
    137 |       if (*((int *)b->read())==0)  // did the user press or release the button
        |             ^~~~~~~~~~~~~~~~
  

• input.cpp:142:44: warning: cast from 'char *' to 'int *' increases required alignment from 1 to 4 [-Wcast-align]
    142 |             if ((b!=b2 || maxdown==0) && *((int *)b2->read())==0)
        |                                            ^~~~~~~~~~~~~~~~~
  

• specs.cpp:219:29: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
    219 |       buf=(void *)(((char *)buf)+copy_size);
        |                             ^
  

• specs.cpp:470:32: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
    470 |   long ret = ::write(fd,(char*)buf,count);
        |                                ^
  

• specs.cpp:715:22: warning: cast from 'char *' to 'spec_entry *' increases required alignment from 1 to 8 [-Wcast-align]
    715 |       spec_entry *se=(spec_entry *)dp;
        |                      ^~~~~~~~~~~~~~~~
  

• ./specs.h:132:9: warning: private field 'fname' is not used [-Wunused-private-field]
    132 |   char *fname;
        |         ^
  

• ./specs.h:133:9: warning: private field 'tmp_write_name' is not used [-Wunused-private-field]
    133 |   char *tmp_write_name;
        |         ^
  

• ./pmenu.h:53:22: warning: explicitly assigning value of variable of type 'psub_menu *' to itself [-Wself-assign]
     53 |   { first=First; Next=Next; win=0; active=0; }
        |                  ~~~~^~~~~
  

• ./pmenu.h:44:14: warning: private field 'next' is not used [-Wunused-private-field]
     44 |   psub_menu *next;
        |              ^
  

• scroller.cpp:387:40: warning: cast from 'const void *' to 'pick_list_item *' drops const qualifier [-Wcast-qual]
    387 |   pick_list_item *a1=(pick_list_item *)a;
        |                                        ^
  

• scroller.cpp:388:40: warning: cast from 'const void *' to 'pick_list_item *' drops const qualifier [-Wcast-qual]
    388 |   pick_list_item *a2=(pick_list_item *)b;
        |                                        ^
  

• ./tools.h:43:8: warning: 'tool_picker::remap' hides overloaded virtual function [-Woverloaded-virtual]
     43 |   void remap(palette *pal, image *screen);
        |        ^
  

• jwindow.cpp:65:5: warning: delete called on non-final 'Jwindow' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
     65 |     delete j;
        |     ^
  

• ./../imlib/event.h:54:35: warning: private field 'last_key' is not used [-Wunused-private-field]
     54 |   int mhere,ewaiting,last_keystat,last_key;
        |                                   ^
  

• video.cpp:353:22: warning: variable length arrays in C++ are a Clang extension [-Wvla-cxx-extension]
    353 |     SDL_Color colors[ncolors];
        |                      ^~~~~~~
  

• ./extend.h:119:43: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    119 |   void set_fxvel(uint8_t xv)      { Fxvel=abs(xv); }
        |                                           ^
  

• ./extend.h:120:43: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    120 |   void set_fyvel(uint8_t yv)      { Fyvel=abs(yv); }
        |                                           ^
  

• ./extend.h:121:44: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    121 |   void set_fxacel(uint8_t xa)     { Fxacel=abs(xa); }
        |                                            ^
  

• ./extend.h:122:44: warning: taking the absolute value of unsigned type 'uint8_t' (aka 'unsigned char') has no effect [-Wabsolute-value]
    122 |   void set_fyacel(uint8_t ya)     { Fyacel=abs(ya); }
        |                                            ^
  

• ./dev.h:135:16: warning: 'dev_term::execute' hides overloaded virtual function [-Woverloaded-virtual]
    135 |   virtual void execute(char *st);
        |                ^
  

• netcfg.cpp:116:18: warning: cast from 'char *' to 'ifield *' increases required alignment from 1 to 8 [-Wcast-align]
    116 |     min_players=((ifield *)(i->get(NET_MIN)->read()))->id-MIN_1+1;
        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• netcfg.cpp:117:18: warning: cast from 'char *' to 'ifield *' increases required alignment from 1 to 8 [-Wcast-align]
    117 |     max_players=((ifield *)(i->get(NET_MAX)->read()))->id-MAX_2+2;
        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• netcfg.cpp:140:12: warning: cast from 'char *' to 'ifield *' increases required alignment from 1 to 8 [-Wcast-align]
    140 |       if (((ifield *)(i->get(LEVEL_BOX)->read()))->id==LVL_2)
        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• netcfg.cpp:142:17: warning: cast from 'char *' to 'ifield *' increases required alignment from 1 to 8 [-Wcast-align]
    142 |       else if (((ifield *)(i->get(LEVEL_BOX)->read()))->id==LVL_4)
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• ./netface.h:116:54: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    116 |   uint16_t get_checksum()            { uint16_t cs=*((uint16_t *)data+1); return lstl(cs); }
        |                                                      ^~~~~~~~~~~~~~~~
  

• ./netface.h:119:7: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    119 |     *((uint16_t *)data+1)=0;
        |       ^~~~~~~~~~~~~~~~
  

• ./netface.h:128:7: warning: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint16_t *' (aka 'unsigned short *') increases required alignment from 1 to 2 [-Wcast-align]
    128 |     *((uint16_t *)data+1)=lstl(cs);
        |       ^~~~~~~~~~~~~~~~
  

• innet.cpp:130:9: warning: variable 'total_usable' set but not used [-Wunused-but-set-variable]
    130 |     int total_usable = 0;
        |         ^
  

• innet.cpp:519:23: warning: variable 'st' set but not used [-Wunused-but-set-variable]
    519 |                 int i,st=0;
        |                       ^
  

• ./imlib/pmenu.h:53:22: warning: explicitly assigning value of variable of type 'psub_menu *' to itself [-Wself-assign]
     53 |   { first=First; Next=Next; win=0; active=0; }
        |                  ~~~~^~~~~
  

• profile.cpp:99:21: warning: cast from 'const void *' to 'prof_info *' drops const qualifier [-Wcast-qual]
     99 |   if (((prof_info *)a)->total_time<((prof_info *)b)->total_time)
        |                     ^
  

• profile.cpp:99:50: warning: cast from 'const void *' to 'prof_info *' drops const qualifier [-Wcast-qual]
     99 |   if (((prof_info *)a)->total_time<((prof_info *)b)->total_time)
        |                                                  ^
  

• profile.cpp:101:26: warning: cast from 'const void *' to 'prof_info *' drops const qualifier [-Wcast-qual]
    101 |   else if (((prof_info *)a)->total_time>((prof_info *)b)->total_time)
        |                          ^
  

• profile.cpp:101:55: warning: cast from 'const void *' to 'prof_info *' drops const qualifier [-Wcast-qual]
    101 |   else if (((prof_info *)a)->total_time>((prof_info *)b)->total_time)
        |                                                       ^
  

• cop.cpp:993:19: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    993 |   if  ( ((view **)a)[0]->kills > ((view **)b)[0]->kills)
        |                   ^
  

• cop.cpp:993:44: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    993 |   if  ( ((view **)a)[0]->kills > ((view **)b)[0]->kills)
        |                                            ^
  

• cop.cpp:995:24: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    995 |   else if  ( ((view **)a)[0]->kills < ((view **)b)[0]->kills)
        |                        ^
  

• cop.cpp:995:49: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    995 |   else if  ( ((view **)a)[0]->kills < ((view **)b)[0]->kills)
        |                                                 ^
  

• cop.cpp:997:22: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    997 |   else if (((view **)a)[0]->player_number > ((view **)b)[0]->player_number)
        |                      ^
  

• cop.cpp:997:55: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    997 |   else if (((view **)a)[0]->player_number > ((view **)b)[0]->player_number)
        |                                                       ^
  

• cop.cpp:999:22: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    999 |   else if (((view **)a)[0]->player_number < ((view **)b)[0]->player_number)
        |                      ^
  

• cop.cpp:999:55: warning: cast from 'const void *' to 'view **' drops const qualifier [-Wcast-qual]
    999 |   else if (((view **)a)[0]->player_number < ((view **)b)[0]->player_number)
        |                                                       ^
  

• statbar.cpp:276:7: warning: variable 'sb_w' set but not used [-Wunused-but-set-variable]
    276 |   int sb_w,sb_h;
        |       ^
  

• statbar.cpp:276:12: warning: variable 'sb_h' set but not used [-Wunused-but-set-variable]
    276 |   int sb_w,sb_h;
        |            ^
  

• clisp.cpp:1962:61: warning: for loop has empty body [-Wempty-body]
   1962 |     { int x=0; view *v=player_list; for (; v; v=v->next,x++); return x; } break;
        |                                                             ^
  

• collide.cpp:166:57: warning: variable 't_centerx' set but not used [-Wunused-but-set-variable]
    166 |   int32_t sx1,sy1,sx2,sy2,tx1,ty1,tx2,ty2,hitx=0,hity=0,t_centerx;
        |                                                         ^
  

• cache.cpp:223:32: warning: cast from 'const void *' to 'int *' drops const qualifier [-Wcast-qual]
    223 |   return cache.compare(*(int *)a,*(int *)b);
        |                                ^
  

• cache.cpp:223:42: warning: cast from 'const void *' to 'int *' drops const qualifier [-Wcast-qual]
    223 |   return cache.compare(*(int *)a,*(int *)b);
        |                                          ^
  

• cache.cpp:310:39: warning: cast from 'const void *' to 'int *' drops const qualifier [-Wcast-qual]
    310 |   return cache.offset_compare(*(int *)a,*(int *)b);
        |                                       ^
  

• cache.cpp:310:49: warning: cast from 'const void *' to 'int *' drops const qualifier [-Wcast-qual]
    310 |   return cache.offset_compare(*(int *)a,*(int *)b);
        |                                                 ^
  

• cache.cpp:556:9: warning: variable 'tcached' set but not used [-Wunused-but-set-variable]
    556 |     int tcached=0;
        |         ^
  

• items.cpp:51:32: warning: variable 'maxy' set but not used [-Wunused-but-set-variable]
     51 |     int j,xp1,yp1,xp2,yp2,maxx,maxy,minx,miny;
        |                                ^
  

• items.cpp:134:32: warning: variable 'maxy' set but not used [-Wunused-but-set-variable]
    134 |     int j,xp1,yp1,xp2,yp2,maxx,maxy,minx,miny;
        |                                ^
  

• ./imlib/tools.h:43:8: warning: 'tool_picker::remap' hides overloaded virtual function [-Woverloaded-virtual]
     43 |   void remap(palette *pal, image *screen);
        |        ^
  

• dev.cpp:281:11: warning: variable 'loop' set but not used [-Wunused-but-set-variable]
    281 |       int loop=0;
        |           ^
  

• dev.cpp:1228:6: warning: cast from 'char *' to 'tile_picker *' increases required alignment from 1 to 8 [-Wcast-align]
   1228 |     ((tile_picker *)forew->read(DEV_FG_PICKER))->recenter(forew->screen);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• dev.cpp:1252:6: warning: cast from 'char *' to 'tile_picker *' increases required alignment from 1 to 8 [-Wcast-align]
   1252 |     ((tile_picker *)forew->read(DEV_FG_PICKER))->recenter(forew->screen);
        |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• dev.cpp:2605:31: warning: cast from 'char *' to 'pick_list *' increases required alignment from 1 to 8 [-Wcast-align]
   2605 |       int val=get_omenu_item(((pick_list *)ev.message.data)->get_selection());
        |                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• dev.cpp:2616:16: warning: cast from 'char *' to 'pick_list *' increases required alignment from 1 to 8 [-Wcast-align]
   2616 |       int val=((pick_list *)ev.message.data)->get_selection();
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• dev.cpp:2950:39: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
   2950 |         scale=lnumber_value(CAR(ao)); ao=CDR(ao);
        |                                       ^
  

• dev.cpp:3002:9: warning: variable 'find' set but not used [-Wunused-but-set-variable]
   3002 |   int i,find=-1,d=cur_fg;
        |         ^
  

• dev.cpp:3059:12: warning: cast from 'char *' to 'tile_picker *' increases required alignment from 1 to 8 [-Wcast-align]
   3059 |           ((tile_picker *)dev_cont->forew->
        |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   3060 |            read(DEV_FG_PICKER))->recenter(dev_cont->forew->screen);
        |            ~~~~~~~~~~~~~~~~~~~
  

• dev.cpp:230:13: warning: unused function 'single_render' [-Wunused-function]
    230 | static void single_render()
        |             ^~~~~~~~~~~~~
  

• ./dev.h:76:7: warning: private field 'area_x1' is not used [-Wunused-private-field]
     76 |   int area_x1,area_y1,area_x2,area_y2;
        |       ^
  

• ./dev.h:76:15: warning: private field 'area_y1' is not used [-Wunused-private-field]
     76 |   int area_x1,area_y1,area_x2,area_y2;
        |               ^
  

• ./dev.h:76:23: warning: private field 'area_x2' is not used [-Wunused-private-field]
     76 |   int area_x1,area_y1,area_x2,area_y2;
        |                       ^
  

• ./dev.h:76:31: warning: private field 'area_y2' is not used [-Wunused-private-field]
     76 |   int area_x1,area_y1,area_x2,area_y2;
        |                               ^
  

• level.cpp:482:27: warning: variable 't_centerx' set but not used [-Wunused-but-set-variable]
    482 |   int32_t tx1,ty1,tx2,ty2,t_centerx;
        |                           ^
  

• level.cpp:534:27: warning: variable 't_centerx' set but not used [-Wunused-but-set-variable]
    534 |   int32_t tx1,ty1,tx2,ty2,t_centerx;
        |                           ^
  

• level.cpp:616:19: warning: variable 'l' set but not used [-Wunused-but-set-variable]
    616 |   game_object *o,*l=NULL,  // l is last, used for delete
        |                   ^
  

• level.cpp:1718:9: warning: variable 'my_player_number' set but not used [-Wunused-but-set-variable]
   1718 |     int my_player_number=-1;
        |         ^
  

• intsect.cpp:173:11: warning: variable 'xdiff' set but not used [-Wunused-but-set-variable]
    173 |   int32_t xdiff,ydiff;
        |           ^
  

• intsect.cpp:173:17: warning: variable 'ydiff' set but not used [-Wunused-but-set-variable]
    173 |   int32_t xdiff,ydiff;
        |                 ^
  

• ./morpher.h:26:7: warning: private field 'end_type' is not used [-Wunused-private-field]
     26 |   int end_type,fleft;
        |       ^
  

• configuration.cpp:39:12: warning: unused function 'binding_for_player' [-Wunused-function]
     39 | static int binding_for_player( int player )
        |            ^~~~~~~~~~~~~~~~~~
  

• ./net/tcpip.h:227:32: warning: cast from 'const void *' to 'char *' drops const qualifier [-Wcast-qual]
    227 |       return ::write(fd,(char*)buf,size);
        |                                ^
  

• game.cpp:1898:42: warning: cast from 'char *' to 'button *' increases required alignment from 1 to 8 [-Wcast-align]
   1898 |                                         ((button *)ev.message.data)->push();
        |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
  

• devsel.cpp:105:11: warning: variable 'blank' set but not used [-Wunused-but-set-variable]
    105 |       int blank=0;
        |           ^
  

• light.cpp:616:3: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
    616 |   register int cx=w;
        |   ^~~~~~~~
  

• light.cpp:617:3: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
    617 |   register uint8_t * di=screen_addr;
        |   ^~~~~~~~
  

• light.cpp:618:3: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
    618 |   register uint8_t * si=remap;
        |   ^~~~~~~~
  

• light.cpp:643:3: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
    643 |   register int dx,dy;           // x and y distances
        |   ^~~~~~~~
  

• light.cpp:650:5: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
    650 |     register int32_t *dt=&(*lon_p)->type;
        |     ^~~~~~~~
  

• light.cpp:754:16: warning: variable 'ly_run' set but not used [-Wunused-but-set-variable]
    754 |   int lx_run=0,ly_run;                     // light block x & y run size in pixels ==  (1<<lx_run)
        |                ^
  

• light.cpp:909:16: warning: variable 'ly_run' set but not used [-Wunused-but-set-variable]
    909 |   int lx_run=0,ly_run;                     // light block x & y run size in pixels ==  (1<<lx_run)
        |                ^