Snippets for mtpaint 3.50.09 from FreeBSD 150amd64

Sourced from https://pkg-status.freebsd.org/beefy23/data/latest-per-pkg/mtpaint/3.50.09_7/150amd64-default.log.

• main.c:291:14: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    291 |         if (warnmax |= flist_top >= FILES_MAX) return;
        |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  

• main.c:319:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    319 |                                 if (warnmax |= flist_top >= flist_len) break;
        |                                     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  

• main.c:331:17: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    331 |                                 if (warnmax |= flist_top >= flist_len) break;
        |                                     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  

• main.c:538:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    538 |                         if (warnmax |= globdata.gl_pathc >= FILES_MAX) break;
        |                             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• main.c:554:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    554 |                         if (warnmax |= globdata.gl_pathc > (PATHC_TYPE)w0) break;
        |                             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• main.c:563:16: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
    563 |                         if (warnmax |= flist_top >= flist_len) break;
        |                             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  

• png.c:3804:2: warning: 'uint16' is deprecated [-Wdeprecated-declarations]
   3804 |         uint16 bpsamp, sampp, xsamp, pmetric, planar, orient, sform;
        |         ^
  

• png.c:3805:2: warning: 'uint16' is deprecated [-Wdeprecated-declarations]
   3805 |         uint16 *sampinfo, *red16, *green16, *blue16;
        |         ^
  

• png.c:3806:2: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   3806 |         uint32 width, height, tw = 0, th = 0, rps = 0;
        |         ^
  

• png.c:3807:2: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   3807 |         uint32 *tr, *raster = NULL;
        |         ^
  

• png.c:3942:3: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   3942 |                 uint32 size;
        |                 ^
  

• png.c:3969:13: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   3969 |                 raster = (uint32 *)_TIFFmalloc(width * height * sizeof(uint32));
        |                           ^
  

• png.c:3969:58: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   3969 |                 raster = (uint32 *)_TIFFmalloc(width * height * sizeof(uint32));
        |                                                                        ^
  

• png.c:4004:3: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   4004 |                 uint32 x0, y0, xstep = tw ? tw : width, ystep = th ? th : rps;
        |                 ^
  

• png.c:4066:4: warning: 'uint32' is deprecated [-Wdeprecated-declarations]
   4066 |                         uint32 x, y, w, h, l;
        |                         ^
  

• png.c:4314:2: warning: 'uint16' is deprecated [-Wdeprecated-declarations]
   4314 |         uint16 rgb[256 * 3];
        |         ^
  

• png.c:4625:10: warning: result of comparison of constant 9223372036854775807 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
   4625 |                 if (tl >= F_LONG_MAX) break; // Limit for what can be handled
        |                     ~~ ^  ~~~~~~~~~~
  

• png.c:5010:10: warning: result of comparison of constant 9223372036854775807 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
   5010 |         if (ofs > F_LONG_MAX) goto fail; // Cannot handle this length
        |             ~~~ ^ ~~~~~~~~~~
  

• png.c:5172:11: warning: result of comparison of constant 9223372036854775793 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
   5172 |                 if (ofs > F_LONG_MAX - BMP_HDR2SIZE) break; // Too far
        |                     ~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
  

• png.c:6878:13: warning: result of comparison of constant 9223372036854775286 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare]
   6878 |                 if ((fofs > F_LONG_MAX - TGA_EXTSIZE - TGA_FSIZE) ||
        |                      ~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  

• layer.c:202:20: warning: passing arguments to 'layer_refresh_list' without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    202 |         layer_refresh_list(layers_total);
        |                           ^
  

• ./layer.h:75:6: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C23, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
     75 | void layer_refresh_list();
        |      ^
  

• wu.c:72:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
     72 | static void Hist3d(inbuf, vwt, vmr, vmg, vmb)   // build 3-D color histogram of counts, r/g/b, c^2
        |             ^
  

• wu.c:128:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    128 | static void M3d(vwt, vmr, vmg, vmb)     // compute cumulative moments.
        |             ^
  

• wu.c:167:17: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    167 | static long int Vol(cube, mmt)                  // Compute sum over a box of any given statistic
        |                 ^
  

• wu.c:187:17: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    187 | static long int Bottom(cube, dir, mmt)
        |                 ^
  

• wu.c:219:17: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    219 | static long int Top(cube, dir, pos, mmt)
        |                 ^
  

• wu.c:259:17: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    259 |         dr = Vol(cube, mr); 
        |                        ^~
  

• wu.c:260:17: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    260 |         dg = Vol(cube, mg); 
        |                        ^~
  

• wu.c:261:17: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    261 |         db = Vol(cube, mb);
        |                        ^~
  

• wu.c:270:52: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    270 |         return( xx - (dr*dr+dg*dg+db*db)/(double)Vol(cube,wt) );    
        |                                                           ^~
  

• wu.c:252:15: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    252 | static double Var(cube)
        |               ^
  

• wu.c:292:29: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    292 |         base_r = Bottom(cube, dir, mr);
        |                                    ^~
  

• wu.c:293:29: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    293 |         base_g = Bottom(cube, dir, mg);
        |                                    ^~
  

• wu.c:294:29: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    294 |         base_b = Bottom(cube, dir, mb);
        |                                    ^~
  

• wu.c:295:29: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    295 |         base_w = Bottom(cube, dir, wt);
        |                                    ^~
  

• wu.c:301:39: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    301 |                 half_r = base_r + Top(cube, dir, i, mr);
        |                                                     ^~
  

• wu.c:302:39: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    302 |                 half_g = base_g + Top(cube, dir, i, mg);
        |                                                     ^~
  

• wu.c:303:39: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    303 |                 half_b = base_b + Top(cube, dir, i, mb);
        |                                                     ^~
  

• wu.c:304:39: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    304 |                 half_w = base_w + Top(cube, dir, i, wt);
        |                                                     ^~
  

• wu.c:281:15: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
    281 | static double Maximize(cube, dir, first, last, cut, whole_r, whole_g, whole_b, whole_w)
        |               ^
  

• wu.c:338:22: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    338 |         whole_r = Vol(set1, mr);
        |                             ^~
  

• wu.c:339:22: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    339 |         whole_g = Vol(set1, mg);
        |                             ^~
  

• wu.c:340:22: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    340 |         whole_b = Vol(set1, mb);
        |                             ^~
  

• wu.c:341:22: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    341 |         whole_w = Vol(set1, wt);
        |                             ^~
  

• wu.c:455:26: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    455 |                 weight = Vol(&cube[k], wt);
        |                                        ^~
  

• wu.c:458:31: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    458 |                         pal[k].red = Vol(&cube[k], mr) / weight;
        |                                                    ^~
  

• wu.c:459:33: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    459 |                         pal[k].green = Vol(&cube[k], mg) / weight;
        |                                                      ^~
  

• wu.c:460:32: warning: incompatible pointer types passing 'int *' to parameter of type 'int (*)[33][33]' [-Wincompatible-pointer-types]
    460 |                         pal[k].blue = Vol(&cube[k], mb) / weight;
        |                                                     ^~
  

• thread.c:254:8: warning: 'g_atomic_int_exchange_and_add' is deprecated: Use 'g_atomic_int_add' instead [-Wdeprecated-declarations]
    254 |                 nx = thread_xadd(&tdata->done, step);
        |                      ^
  

• thread.c:305:8: warning: 'g_thread_create' is deprecated: Use 'g_thread_new' instead [-Wdeprecated-declarations]
    305 |                 if (!g_thread_create((GThreadFunc)thread, tp, FALSE, NULL))
        |                      ^